Weather modules dont show up anymore

[rejas]

After #2161 got merged into develop my weather modules (current & forecast) dont show up anymore.

Not sure what happens but IMHO that PR seems to be incomplete and breaks existing configs and should therefor should be reworked.

[MichMich]

Thanks for notifying me.
Reverted the PR: #2165

[Snille]

Hmm... Sorry, don't know why its not working for you, all is good here, my weather modules keeps showing them self even if I have hidden them with another module. Do you not experience this?

[rejas]

I dont hide my weather modules from other modules. How do you do that?

[sdetweil]

@rejas
MMM-Voice will allow you to hide individual modules on command
my MMM-SleepWake provides an option to hide all modules instead of turning off the screen (where not possible)

there are others

[Snille]

@rejas I'm using my own MMM-Modulebar to hide and show modules. And also I'm using "profiles" MMM-ProfileSwitcher to show different modules for different users (@ different times of the day). But the problem is that both the weather modules do not "respect" that they have been hidden. They keep showing up when they update (default every 10 minutes).

[sdetweil]

their getDom() routines should become aware of the state and not draw when hidden
they should have suspend() and resume() methods that track the state

[MichMich]

This might be an issue in the core itself. getDom should not be called when they are hidden.

[sdetweil]

@MichMich yep. updateDom() does not check the visibility state before calling getDom()

[MichMich]

@Snille @rejas Does #2166 solve the issue?

[rejas]

No, I only see a big "undefined" in the place of the module. See my comment in the PR for possible reason.

[MichMich]

I added a new commit returning an empty promise. Could you give it another try, @rejas?

[rejas]

The undefined was an error on my side. Still, returning an empty promise is the better way I think. So: thumbs up from me for this.

[sdetweil]

looks good.. i think the real bug was in updateDomWithContent,
but this approach is cleaner

var updateDomWithContent = function (module, speed, newHeader, newContent) {
		return new Promise(function (resolve) {
			if (module.hidden || !speed) {                       // <--- maybe if(!module.hidden && !speed)// speed handled later