Bad font for non latin users

[alexey-gamov]

Fonts bug in MagicMirror

Platform: MagicMirrorOS on Raspberry Pi 2 .
MagicMirror² Version: 2.19.0

Description:

In this update fonts package was changed from roboto-fontface-bower to fontsource (2dcf55e).
CSS file roboto.css uses only latin subset for loading woff files. It is not fair = fonts must consist all world chars.

Way to fix:

Change roboto-latin-100-normal.woff2 to roboto-all-100-normal.woff2 and etc.

Expected Results: Fonts are still great with non US characters.
Actual Results: Fonts are ugly. Need to add custom @font-face from Google.

[khassel]

It is not fair = fonts must consist all world chars.

that was not intentional

Can you provide a PR to fix this? Otherwise I will create one ...

[alexey-gamov]

It is not fair = fonts must consist all world chars.

that was not intentional

Can you provide a PR to fix this? Otherwise I will create one ...

Last package was international :)
Unfortunately am not expert in node modules, it will be better if you can fix that issue..

[outlying]

I confirm that, 2.19.0 update "broke" fonts in news module and greeting module (see ń character) probably in more places too

[MichMich]

Can anyone confirm the PR of @khassel solves the issue?

[ayuhito]

Fontsource maintainer here. It may be better for you to reference the source CSS files itself so you can write the appropriate @font-face declarations instead to support international users. The unicode-range CSS selector is a key thing that @khassel’s PR is missing that prevents woff2 files from being used effectively.

Example CSS file.

That being said, since this is an offline Electron application (I’m just guessing), the current implementation with just the woff files containing all the subsets is completely fine. I’m not sure if we need to amend @khassel’s PR in that context. If it’s an online application, then I would recommend the woff2 approach.

Additionally when fontsource/fontsource#234 is implemented, I think that will help simplify your build process a lot more. Feel free to keep tabs on that issue!

[rejas]

Can anyone confirm the PR of @khassel solves the issue?

I can confirm that with his PR the ń looks better (when used in the compliments module) Not sure if that solves it for ALL possible letters.