add sun/moon rise/set times#1885
Merged
MichMich merged 5 commits intoJan 18, 2020
Merged
Conversation
Icons become bold when the object is above the horizon. Also shows percent of moon illumination.
|
On old iPad Safari toLocaleString not working |
Contributor
Author
|
@hangorazvan thanks, I'll try to get it fixed soon. Additionally, it appears that moonrise/moonset times are not quite correct... |
dtreskunov
added a commit
to dtreskunov/MagicMirror
that referenced
this pull request
Feb 10, 2020
1. as reported on MagicMirrorOrg#1885, toLocaleString is not supported on old iPad Safari 2. SunCalc.getMoonTimes returns moonRise/moonSet times for the given date, so moonRise can be after moonSet. We want to display the most relevant times, which are today's moonRise and the next moonSet.
dtreskunov
added a commit
to dtreskunov/MagicMirror
that referenced
this pull request
Feb 10, 2020
1. as reported on MagicMirrorOrg#1885, toLocaleString is not supported on old iPad Safari 2. SunCalc.getMoonTimes returns moonRise/moonSet times for the given date, so moonRise can be after moonSet. We want to display the most relevant times, which are today's moonRise and the next moonSet.
|
Here another error, on 15 February morning:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Icons become bright when the object is above the horizon. Also shows
time until next sunset/sunrize and percent of moon illumination.