Few changes made on the Smartmirror Project#20
Closed
3DJupp wants to merge 45 commits into
Closed
Conversation
UTF-8 Fix
Translation of moment.js,compliments and UI
More languages
Language selection based on browser preferences, override is possible with a language-tag http://127.0.0.1/?lang=de
Added support for multiple calendars
Increased Interval between news-feed-refresh (7s to 15s)
Display only a few (7 in this example) calendar entrys.
Newsfeed , Location, Language ,(public transport widget is prepared)
http://momentjs.com/ moment+locales.js
Multi Calendar support should be included within the main.js
Please enter an API Key, in order to use Weather Data
MichMich
pushed a commit
that referenced
this pull request
Apr 23, 2016
khassel
pushed a commit
that referenced
this pull request
May 12, 2026
Small cleanup PR to close three CodeQL alerts, without changing app behavior. - [#18](https://github.com/MagicMirrorOrg/MagicMirror/security/code-scanning/18) in `js/loader.js` - [#19](https://github.com/MagicMirrorOrg/MagicMirror/security/code-scanning/19) in `js/socketclient.js` - [#20](https://github.com/MagicMirrorOrg/MagicMirror/security/code-scanning/20) in `tests/electron/modules/calendar_spec.js` For `Loader` and `MMSocket`, make the global export explicit via `globalThis` (instead of suppressing `no-unused-vars`). For calendar tests, remove the unused debug helper `logAllText`. Also includes a tiny e2e cleanup: `MM_PORT` is cleared in `afterAll`. Outcome: Three open CodeQL alerts are addressed with small, low-risk changes. The global intent for `Loader` and `MMSocket` is explicit, dead test helper code is removed, and e2e test state is cleaned up more reliably between runs. With this, all current [code scanning issues](https://github.com/MagicMirrorOrg/MagicMirror/security/code-scanning) should be resolved in the develop branch 🎈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translation (NE,DL,FR,EN etc) compliments,moments and all other items
Language override (if browser locale is wrong) just enter http://smartmirror/?en or de
Fixed .1f Temperatures
Support for multiple Calendars (just config that in calendar.php)
Updated:moment.js and Temperature icons