Skip to content

Fix calendar when no DTEND record in event #2178

Merged
MichMich merged 14 commits into
MagicMirrorOrg:developfrom
sdetweil:fix-cal2
Nov 6, 2020
Merged

Fix calendar when no DTEND record in event #2178
MichMich merged 14 commits into
MagicMirrorOrg:developfrom
sdetweil:fix-cal2

Conversation

@sdetweil

@sdetweil sdetweil commented Oct 26, 2020

Copy link
Copy Markdown
Collaborator

fixes #2177 #2171 #2180

@sdetweil sdetweil changed the base branch from master to develop October 26, 2020 15:09
@rejas

rejas commented Oct 26, 2020

Copy link
Copy Markdown
Collaborator

You forgot to base it against develop branch :-)

@sdetweil

Copy link
Copy Markdown
Collaborator Author

@rejas, yeh, wish GH project def could force that.. fixed

@rejas

rejas commented Oct 26, 2020

Copy link
Copy Markdown
Collaborator

I think its possible to set the develop branch as the main "working" branch for a project....

@sdetweil

Copy link
Copy Markdown
Collaborator Author

yep, settings, Branches

Default branch
The default branch is considered the “base” branch in your repository, against which all pull requests and code commits are automatically made, unless you specify a different branch.

Comment thread modules/default/calendar/calendarfetcher.js
@sdetweil

Copy link
Copy Markdown
Collaborator Author

sent back

@ghost

ghost commented Oct 27, 2020

Copy link
Copy Markdown

yes is working

@sdetweil

Copy link
Copy Markdown
Collaborator Author

great, thanks

@ghost

ghost commented Oct 27, 2020

Copy link
Copy Markdown

thank you!

…also update windows zones to include old offset based strings (UTC+05:00) US Eastern and Canada
Comment thread modules/default/calendar/calendarfetcher.js
@sdetweil

Copy link
Copy Markdown
Collaborator Author

i get this from commit

🔍  Finding changed files since git revision b73cfd8.
🎯  Found 1 changed file.
✅  Everything is awesome!
[fix-cal2 82c742f] fix prettier problems, was run on commit before
 1 file changed, 9 insertions(+), 9 deletions(-)
(base) sam@sams:~/MagicMirror.2.13$ 

@MichMich MichMich merged commit 3220702 into MagicMirrorOrg:develop Nov 6, 2020
@MichMich

MichMich commented Nov 6, 2020

Copy link
Copy Markdown
Collaborator

Thanks Sam! Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

calendar full date event off by one day when DTEND not specified in ical entry

3 participants