Skip to content

English doesn't have a "day after tomorrow" word #2889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichMich merged 3 commits into from
Jul 28, 2022
Merged

English doesn't have a "day after tomorrow" word #2889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66fffc9
English doesn't have a "day after tomorrow" word
MikeBishop May 10, 2022
65e87ae
CHANGELOG
MikeBishop Jul 25, 2022
0c1e5ea
Use German as the base for tests
MikeBishop Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ _This release is scheduled to be released on 2022-10-01._

## Updated

- Removed DAYAFTERTOMORROW from English

## Fixed

- Broadcast all calendar events while still honoring global and per-calendar maximumEntries.
Expand Down
6 changes: 4 additions & 2 deletions tests/e2e/translations_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ describe("Translations", function () {
dom.window.onload = function () {
const { Translator } = dom.window;

Translator.load(mmm, translations.en, false, function () {
Translator.load(mmm, translations.de, false, function () {
base = Object.keys(Translator.translations[mmm.name]).sort();
done();
});
Expand All @@ -175,8 +175,10 @@ describe("Translations", function () {
console.log(missing);
});

// Using German as the base rather than English, since
// at least one translated word doesn't exist in English.
for (let language in translations) {
if (language === "en") {
if (language === "de") {
continue;
}

Expand Down
1 change: 0 additions & 1 deletion translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

"TODAY": "Today",
"TOMORROW": "Tomorrow",
"DAYAFTERTOMORROW": "In 2 days",
"RUNNING": "Ends in",
"EMPTY": "No upcoming events.",
"WEEK": "Week {weekNumber}",
Expand Down