Skip to content

Add (in Alert module) templateName parameter #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rejas merged 3 commits into from
Jan 26, 2023
+3 −2
Merged

Add (in Alert module) templateName parameter #3009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e50ed1
Add templateName parameter
rajniszp Jan 15, 2023
b33c0ab
Update changelog
rajniszp Jan 15, 2023
1b221f8
Merge branch 'develop' into develop
rejas Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ _This release is scheduled to be released on 2023-04-01._
- Added tests for hourly weather forecast
- Added possibility to ignore MagicMirror repo in updatenotification module
- Added Pirate Weather as new weather provider (#3005)
- Added possibility to use your own templates in Alert module
- Added error message if `<modulename>.js` file is missing in module folder to get a hint in the logs (#2403)

### Removed
Expand Down
4 changes: 2 additions & 2 deletions modules/default/alert/alert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Module.register("alert", {
},

async showNotification(notification) {
const message = await this.renderMessage("notification", notification);
const message = await this.renderMessage(notification.templateName || "notification", notification);

new NotificationFx({
message,
Expand All @@ -90,7 +90,7 @@ Module.register("alert", {
this.toggleBlur(true);
}

const message = await this.renderMessage("alert", alert);
const message = await this.renderMessage(alert.templateName || "alert", alert);

// Store alert in this.alerts
this.alerts[sender.name] = new NotificationFx({
Expand Down