Skip to content

Fix weathergov provider hourly weather forecast #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khassel merged 4 commits into from
Jan 16, 2023
Merged

Fix weathergov provider hourly weather forecast #3011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b83694b
Remove broken and useless conversion call
Jan 16, 2023
5ee9187
Remove useless field
Jan 16, 2023
16a3cbf
Convert windSpeed from km/h to m/s
Jan 16, 2023
53dff94
Update CHANGELOG
Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ _This release is scheduled to be released on 2023-04-01._
### Fixed

- Fix wrong day labels in envcanada forecast (#2987)
- Fix weathergov provider hourly forecast (#3008)

## [2.22.0] - 2023-01-01

Expand Down
4 changes: 2 additions & 2 deletions modules/default/weather/providers/weathergov.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,9 @@ WeatherProvider.register("weathergov", {
} else {
weather.windSpeed = forecast.windSpeed.slice(0, forecast.windSpeed.search(" "));
}
weather.windDirection = this.convertWindDirection(forecast.windDirection);
weather.windSpeed = WeatherUtils.convertWindToMs(weather.windSpeed);
weather.windDirection = forecast.windDirection;
weather.temperature = forecast.temperature;
weather.tempUnits = forecast.temperatureUnit;
// use the forecast isDayTime attribute to help build the weatherType label
weather.weatherType = this.convertWeatherType(forecast.shortForecast, forecast.isDaytime);

Expand Down