Skip to content

Fix empty news feed stopping the feed from ever updating again #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rejas merged 2 commits into from
Mar 11, 2023
Merged

Fix empty news feed stopping the feed from ever updating again #3062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b52f75
Fix empty feeds causing the news feed to stop updating until restart
buxxi Mar 11, 2023
ce59c5f
changelog entry
buxxi Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ _This release is scheduled to be released on 2023-04-01._
- The wind direction arrow now points in the direction the wind is flowing, not into the wind (#3019)
- Fix precipitation css styles and rounding value
- Fix wrong vertical alignment of calendar title column when wrapEvents is true (#3053)
- Fix empty news feed stopping the reload forever

## [2.22.0] - 2023-01-01

Expand Down
6 changes: 5 additions & 1 deletion modules/default/newsfeed/newsfeedfetcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,18 @@ const NewsfeedFetcher = function (url, reloadInterval, encoding, logFeedWarnings

parser.on("end", () => {
this.broadcastItems();
scheduleTimer();
});

parser.on("error", (error) => {
fetchFailedCallback(this, error);
scheduleTimer();
});

//"end" event is not broadcast if the feed is empty but "finish" is used for both
parser.on("finish", () => {
scheduleTimer();
});

parser.on("ttl", (minutes) => {
try {
// 86400000 = 24 hours is mentioned in the docs as maximum value:
Expand Down