Skip to content

Fix weathergov api precipitationLastHour #3125

Merged
khassel merged 3 commits into
MagicMirrorOrg:developfrom
JasonStieber:develop
Jun 28, 2024
Merged

Fix weathergov api precipitationLastHour #3125
khassel merged 3 commits into
MagicMirrorOrg:developfrom
JasonStieber:develop

Conversation

@JasonStieber

Copy link
Copy Markdown
Contributor

Pull request fixes small big in weathergov api format mismatch #3124

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #3125 (562efc0) into develop (e985e99) will increase coverage by 0.06%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop    #3125      +/-   ##
===========================================
+ Coverage    25.55%   25.61%   +0.06%     
===========================================
  Files           53       53              
  Lines        11464    11464              
===========================================
+ Hits          2930     2937       +7     
+ Misses        8534     8527       -7     
Impacted Files Coverage Δ
modules/default/weather/providers/weathergov.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Comment thread modules/default/weather/providers/weathergov.js Outdated
@rejas rejas changed the title Develop Fix weathergov api precipitationLastHour Jun 18, 2023
Comment thread package.json Outdated
@khassel

khassel commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

@JasonStieber can you make the requested changes?

@rejas

rejas commented Jan 18, 2024

Copy link
Copy Markdown
Collaborator

pinging @JasonStieber in the hope he picks this PR up again

@khassel

khassel commented Jun 22, 2024

Copy link
Copy Markdown
Collaborator

Looking into the data getting from the weather gov api there is still a property precipitationLastHour:

grafik

@rejas So we could implement a logical change to use precipitationLast3Hours if precipitationLastHour is null or close this PR.

@rejas

rejas commented Jun 24, 2024

Copy link
Copy Markdown
Collaborator

@rejas So we could implement a logical change to use precipitationLast3Hours if precipitationLastHour is null or close this PR.

I would vote for the logical change. And you and @sdetweil ?

@khassel

khassel commented Jun 27, 2024

Copy link
Copy Markdown
Collaborator

I would vote for the logical change.

I implemented this now.

@khassel khassel requested a review from rejas June 27, 2024 21:22
@khassel khassel merged commit c89c3ed into MagicMirrorOrg:develop Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants