Updated Weather module Met Office API Gateway migration #3384#3428
Closed
serena-fan wants to merge 1 commit into
Closed
Updated Weather module Met Office API Gateway migration #3384#3428serena-fan wants to merge 1 commit into
serena-fan wants to merge 1 commit into
Conversation
Contributor
|
Hi @serena-fan - i reviewed your change and don't think this fixed the issue 3384. I have put in a new pull request that fixes this with some very minor changes. |
Collaborator
|
Superseeded by #3499 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I took a look at the existing repository and the Met Office API documentation. I made some changes to config/config.js file and created a new file modules/default/weather/providers/metoffice.js. I hope this helps with the migration process for updating the weather module to the Met Office API!
Please let me know if there are any potential issues and more additions that might be needed!