Skip to content

Updated to new notification name DOM_OBJECTS_UPDATED -> MODULE_DOM_UPDATED #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rejas merged 2 commits into from
Sep 19, 2024
Merged

Updated to new notification name DOM_OBJECTS_UPDATED -> MODULE_DOM_UPDATED #3548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e130200
Updated new notification name to MODULE_DOM_UPDATED for clarity
ryan-d-williams Sep 19, 2024
5343172
Updated changelog with new notification name
ryan-d-williams Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ _This release is scheduled to be released on 2024-10-01._
- [core] Add spelling check (cspell): `npm run test:spelling` and handle spelling issues (#3544)
- [core] removed `config.paths.vendor` (could not work because `vendor` is hardcoded in `index.html`), renamed `config.paths.modules` to `config.foreignModulesDir`, added variable `MM_CUSTOMCSS_FILE` which - if set - overrides `config.customCss`, added variable `MM_MODULES_DIR` which - if set - overrides `config.foreignModulesDir` (#3530)
- [core] elements are now removed from `index.html` when loading script or stylesheet files fails
- [core] Added `DOM_OBJECTS_UPDATED` notification each time the DOM is re-rendered via `updateDom` (#3534)
- [core] Added `MODULE_DOM_UPDATED` notification each time the DOM is re-rendered via `updateDom` (#3534)

### Removed

Expand Down
2 changes: 1 addition & 1 deletion js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ const MM = (function () {
// Further implementation is done in the private method.
updateDom(module, updateOptions).then(function () {
// Once the update is complete and rendered, send a notification to the module that the DOM has been updated
sendNotification("DOM_OBJECTS_UPDATED", null, null, module);
sendNotification("MODULE_DOM_UPDATED", null, null, module);
});
},

Expand Down