Skip to content

feat(compliments): add configuration for refreshing remote file on interval #3608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xsorifc28 wants to merge 4 commits into from
Closed

feat(compliments): add configuration for refreshing remote file on interval #3608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a36856c
feat(compliments): add configuration for refreshing remote file perio…
xsorifc28 Oct 29, 2024
a7f8303
Update compliments.js
xsorifc28 Oct 29, 2024
aa9e083
Update compliments.js
xsorifc28 Oct 29, 2024
e46bdbd
Update CHANGELOG.md
xsorifc28 Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ Thanks to: @bugsounet, @dkallen78, @jargordon, @khassel, @KristjanESPERANTO, @Ma

### Added

- [compliments] Added config for refreshing the remote file on an interval (default - no refresh)
- [compliments] Added support for cron type date/time format entries mm hh DD MM dow (minutes/hours/days/months and day of week) see https://crontab.cronhub.io for construction (#3481)
- [core] Check config at every start of MagicMirror² (#3450)
- [core] Add spelling check (cspell): `npm run test:spelling` and handle spelling issues (#3544)
Expand Down
8 changes: 8 additions & 0 deletions modules/default/compliments/compliments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Module.register("compliments", {
},
updateInterval: 30000,
remoteFile: null,
remoteFileRefreshInterval: null,
fadeSpeed: 4000,
morningStartTime: 3,
morningEndTime: 12,
Expand Down Expand Up @@ -41,6 +42,13 @@ Module.register("compliments", {
const response = await this.loadComplimentFile();
this.config.compliments = JSON.parse(response);
this.updateDom();
if (this.config.remoteFileRefreshInterval != null) {
this.remoteFileRefreshFunc = setInterval(() => {
const response = await this.loadComplimentFile();
this.config.compliments = JSON.parse(response);
this.lastIndexUsed = -1;
}, this.config.remoteFileRefreshInterval)
}
}
let minute_sync_delay = 1;
// loop thru all the configured when events
Expand Down