set name and path in module init#3710
Closed
khassel wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
test fails will be fixed with #3709 |
Collaborator
|
yeh, I dont think we should go that way |
Collaborator
Author
|
o.k. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a solution for #3708
I set it to draft because I'm not sure if it should be merged.
With this change the
this.namewill now work in theinitfunction but for get this working in a module you have to copy the content of the node_helperinitinto your module. This is nothing new, you have to do the same for e.g.start.AFAIS the used construction in
js/class.jsmisses inheritence for this.