Skip to content

Fix calendar unit test so it uses 1 day more than a full year for yearly recurring events test #3833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khassel merged 1 commit into from
Jul 2, 2025
Merged

Fix calendar unit test so it uses 1 day more than a full year for yearly recurring events test #3833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ Thanks to: @dathbe.

- [core] Update dependencies including electron to v37 (#3831)

### Fixed

- [calendar] Fixed broken unittest that only broke at 1st of july and 1st of january (#3830)

## [2.32.0] - 2025-07-01

Thanks to: @bughaver, @bugsounet, @khassel, @KristjanESPERANTO, @plebcity, @rejas, @sdetweil.
Expand Down
4 changes: 1 addition & 3 deletions tests/unit/modules/default/calendar/calendar_fetcher_utils_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ describe("Calendar fetcher utils test", () => {
excludedEvents: [],
includePastEvents: false,
maximumEntries: 10,
maximumNumberOfDays: 365
maximumNumberOfDays: 367
};

describe("filterEvents", () => {
Expand Down Expand Up @@ -53,7 +53,6 @@ describe("Calendar fetcher utils test", () => {
expect(filteredEvents[1].title).toBe("upcomingEvent");
});

/*
it("should return the correct times when recurring events pass through daylight saving time", () => {
const data = ical.parseICS(`BEGIN:VEVENT
DTSTART;TZID=Europe/Amsterdam:20250311T090000
Expand Down Expand Up @@ -87,7 +86,6 @@ END:VEVENT`);
expect(januaryFirst[0].startDate).toEqual(januaryMoment.format("x"));
expect(julyFirst[0].startDate).toEqual(julyMoment.format("x"));
});
*/

it("should return the correct moments based on the timezone given", () => {
const data = ical.parseICS(`BEGIN:VEVENT
Expand Down