Fix Issue 24#25
Merged
Merged
Conversation
Add tests to the implemantation and improve issue24 test
Modify test_issue24 to verify it not raises
Also improve tests
TIGirardi
commented
Apr 18, 2020
| self.assertTrue(d[0].startswith('HAMT')) | ||
| return d[1] | ||
|
|
||
| def test_array_node_update_in_place_count(self): |
Contributor
Author
There was a problem hiding this comment.
This test is crashing the interpreter on master
1st1
approved these changes
Apr 22, 2020
Member
|
Thanks so much for fixing this. Debugging C code like this one isn't easy, really appreciate this. While reviewing the fixes to I'll merge the PR as is, although I will probably change the testing strategy to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#24
MapNode_Array wasn't incrementing on inplace insertions
Related #26