Skip to content

Add __contains__ to MapKeys #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elprans merged 1 commit into from
Jul 21, 2023
Merged

Add __contains__ to MapKeys #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions immutables/_map.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2810,9 +2810,23 @@ map_new_items_view(MapObject *o)
/////////////////////////////////// _MapKeys_Type


static int
map_tp_contains(BaseMapObject *self, PyObject *key);

static int
_map_keys_tp_contains(MapView *self, PyObject *key)
{
return map_tp_contains((BaseMapObject *)self->mv_obj, key);
}

static PySequenceMethods _MapKeys_as_sequence = {
.sq_contains = (objobjproc)_map_keys_tp_contains,
};

PyTypeObject _MapKeys_Type = {
PyVarObject_HEAD_INIT(NULL, 0)
"keys",
.tp_as_sequence = &_MapKeys_as_sequence,
VIEW_TYPE_SHARED_SLOTS
};

Expand Down
1 change: 1 addition & 0 deletions immutables/_protocols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
class MapKeys(Protocol[KT_co]):
def __len__(self) -> int: ...
def __iter__(self) -> Iterator[KT_co]: ...
def __contains__(self, __key: object) -> bool: ...


class MapValues(Protocol[VT_co]):
Expand Down
4 changes: 4 additions & 0 deletions tests/test_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,6 +1395,10 @@ def test_kwarg_named_col(self):
self.assertEqual(dict(self.Map(a=0, col=1)), {"a": 0, "col": 1})
self.assertEqual(dict(self.Map({"a": 0}, col=1)), {"a": 0, "col": 1})

def test_map_keys_contains(self):
m = self.Map(foo="bar")
self.assertTrue("foo" in m.keys())


class PyMapTest(BaseMapTest, unittest.TestCase):

Expand Down