Fix ref issue when protocol is in Cython#399
Merged
fantix merged 1 commit intoMagicStack:masterfrom Feb 15, 2021
Merged
Conversation
Member
Perhaps we should also fix this in CPython 3.9. |
1st1
reviewed
Feb 13, 2021
fantix
force-pushed
the
fix-cython-ref
branch
from
a984c3a to
630b9e0
Compare
1st1
reviewed
Feb 15, 2021
1st1
reviewed
Feb 15, 2021
Because `context.run()` doesn't hold reference to the callable, when e.g. the protocol is written in Cython, the callbacks were not guaranteed to hold the protocol reference. This PR fixes the issue by explicitly add a reference before `context.run()` calls. Refs geldata/gel#2222
fantix
force-pushed
the
fix-cython-ref
branch
from
630b9e0 to
27935b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
context.run()doesn't hold reference to the callable, when e.g. the protocol is written in Cython, the callbacks were not guaranteed to hold the protocol reference. This PR fixes the issue by explicitly add a reference beforecontext.run()calls.Refs geldata/gel#2222