Skip to content

Remove the undefined type from optional property #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keith-CY merged 2 commits into from
Oct 18, 2022
Merged

Remove the undefined type from optional property #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4b6c6c
Remove the undefined type from optional property
deepsource-autofix[bot] Oct 18, 2022
bc1d49f
fix: remove undefined type from optional property
Keith-CY Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ckb-indexer/src/type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export interface GetCellsResults {
export interface SearchKeyFilter {
sizeLimit?: number;
order?: Order;
lastCursor?: string | undefined;
lastCursor?: string;
}

export interface OutputToVerify {
Expand Down
4 changes: 2 additions & 2 deletions packages/neuron-wallet/src/database/address/meta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ export default class AddressMeta implements Address {
balance?: string
version?: AddressVersion
description?: string
isImporting?: boolean | undefined
usedByAnyoneCanPay?: boolean | undefined
isImporting?: boolean
usedByAnyoneCanPay?: boolean

constructor(
walletId: string,
Expand Down
4 changes: 2 additions & 2 deletions packages/neuron-wallet/src/models/address.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ export interface Address {
balance?: string
version?: AddressVersion
description?: string
isImporting?: boolean | undefined
usedByAnyoneCanPay?: boolean | undefined
isImporting?: boolean

@yanguoyu yanguoyu Oct 18, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nervosnetwork/neuron/blob/4de122604aef9f5d13f593a6344061994022aa38/packages/neuron-wallet/src/database/address/meta.ts#L23-L24
Here also can be remove undefined.

@Keith-CY Keith-CY Oct 18, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed by bc1d49f

usedByAnyoneCanPay?: boolean
}