fix: remove unsafe exec() in NAImage.c#65
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
code/NALib/src/NAVisual/Core/NAImage.c.Vulnerability
V-001code/NALib/src/NAVisual/Core/NAImage.c:111Description: The NAImage component allocates pixel data buffers using naMalloc(na_GetImageDataSize(image)) at line 111 and naMalloc(dataSize) at line 135. Image dimensions (width, height, bytes-per-pixel) are read from attacker-controlled file content without overflow-safe validation. The multiplication in na_GetImageDataSize can overflow a fixed-width integer when given large dimension values, producing a near-zero allocation size. Subsequent pixel data writes then overflow the undersized buffer into adjacent heap memory, enabling heap metadata corruption and arbitrary code execution.
Changes
code/NALib/src/NAVisual/Core/NAImage.cVerification
Automated security fix by OrbisAI Security