test: deletion strategy integration- testcontainers(MAPCO-10628)#32
Open
almog8k wants to merge 8 commits into
Open
test: deletion strategy integration- testcontainers(MAPCO-10628)#32almog8k wants to merge 8 commits into
almog8k wants to merge 8 commits into
Conversation
…detailed failure reasons
|
🎫 Related Jira Issue: MAPCO-10628 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a comprehensive integration test helper suite for S3 and filesystem-backed tile deletion strategies, introduces new test fakes for tile deletion, and improves test configuration and scripts. The main changes include new helper modules for Minio/S3 and FS test environments, utilities for generating tile ranges and paths, and updates to test scripts and dependencies.
Integration test infrastructure:
minioContainer.tsto spin up or connect to a Minio S3-compatible service for testing.s3TestKit.tsfor S3 bucket and object management, including bulk operations and client creation.fsTestKit.tsfor creating, writing, listing, and removing files and directories in a temporary filesystem.backendFixtures.tsto orchestrate S3 and FS test environments, including provider wiring and teardown.testPoller.tsto wire up the poller, strategies, and queue mocks for single-task test runs.tileFixtures.tsfor generating tile data, paths, and extra test tiles to verify correct deletion.Test fakes and utilities:
tilesDeletionFakes.tsfor generating fake tile deletion parameters and ranges for testing.tests/helpers/fakes/index.tsto export the new tile deletion fakes.Test configuration and scripts:
package.json:testscript to run both unit and integration tests, and added a dedicatedtest:integrationscript.testcontainersas a dev dependency for running Minio in tests.eslint.config.mjsto ignore the new integration test config file.Other improvements:
S3_MAX_DELETE_BATCHa named export for use in test helpers. [1] [2]gisDomain: rasterto Helm values for improved chart configuration.These changes lay the groundwork for robust integration testing of storage provider strategies, ensuring correctness across S3 and filesystem backends.