Coveralls is failing due to small percentage changes

[geographika]

Recent pull requests are showing as failing even when actual coverage is not reduced (see discussion here). This is caused by the number of lines of code increase as the percentage of code coverage reduces.

The percentage change rate can be set at https://coveralls.io/github/mapserver/mapserver/settings. @jmckenna I think you have access to this?

Maybe setting to 0.1% would mean we get the nice green ticks without risking adding too much untested code?

[jmckenna]

I had already changed this early yesterday to 1%

[jmckenna]

Confirmed, the settings are already at 1% (I did this for my pull request a few days ago). Checking why it is still erroring...

[jmckenna]

The settings already match those in that ticket (that was the same ticket I used yesterday morning to change the settings). Checking into why they are not applied in builds...

[jmckenna]

[geographika]

Strange - sorry @jmckenna - thought it might be a quick change..
Perhaps it is something to do with pull requests not being on the main branch. I'll test on one of my repos to see if I can recreate.

[jmckenna]

From 2018 from the developer: "Currently default behavior is fail for any decrease. If your coverage threshold for failure is set, the coverage decrease threshold for failure is ignored."

[jmckenna]

checking tickets for coveralls to see reports of this...

[geographika]

Ah ok - so maybe remove the 70% value and leave the 0.1%?

[jmckenna]

yes i was thinking the same...updating now...

[jmckenna]

[jmckenna]

By the way, when I was looking at this yesterday I was unable to 're-trigger' coveralls for an existing pull request. Let's try a new pull request.

[jmckenna]

(I think we can safely merge the py3.8 ticket, and test this with new pull request)

[jmckenna]

That changed worked! Thanks @geographika

[geographika]

Thanks @jmckenna!