-
Notifications
You must be signed in to change notification settings - Fork 406
Static Adapt methods now work as extension methods and fixed docs where 'OfType' should be 'ForType'. Also shows Enum -> string failure on compile with Explicit on. #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| using System; | ||
| using Mapster.Tests.Classes; | ||
| using NUnit.Framework; | ||
| using Should; | ||
|
|
||
| namespace Mapster.Tests | ||
| { | ||
| /// <summary> | ||
| /// Not trying to test core testing here...just a few tests to make sure the extension method approach doesn't hose anything | ||
| /// </summary> | ||
| [TestFixture] | ||
| public class WhenMappingWithExtensionMethods | ||
| { | ||
|
|
||
| [Test] | ||
| public void Adapt_With_Source_And_Destination_Type_Succeeds() | ||
| { | ||
| TypeAdapterConfig<Product, ProductDTO>.NewConfig() | ||
| .Compile(); | ||
|
|
||
| var product = new Product { Id = Guid.NewGuid(), Title = "ProductA", CreatedUser = new User { Name = "UserA" } }; | ||
|
|
||
| var dto = product.Adapt<Product, ProductDTO>(); | ||
|
|
||
| dto.ShouldNotBeNull(); | ||
| dto.Id.ShouldEqual(product.Id); | ||
| } | ||
|
|
||
| [Test] | ||
| public void Adapt_With_Source_And_Destination_Types_And_Config_Succeeds() | ||
| { | ||
| var config = new TypeAdapterConfig(); | ||
| config.ForType<Product, ProductDTO>(); | ||
|
|
||
|
|
||
| var product = new Product { Id = Guid.NewGuid(), Title = "ProductA", CreatedUser = new User { Name = "UserA" } }; | ||
|
|
||
| var dto = product.Adapt<Product, ProductDTO>(config); | ||
|
|
||
| dto.ShouldNotBeNull(); | ||
| dto.Id.ShouldEqual(product.Id); | ||
| } | ||
|
|
||
| [Test] | ||
| public void Adapt_With_Destination_Type_Succeeds() | ||
| { | ||
| TypeAdapterConfig<Product, ProductDTO>.NewConfig() | ||
| .Compile(); | ||
|
|
||
| var product = new Product { Id = Guid.NewGuid(), Title = "ProductA", CreatedUser = new User { Name = "UserA" } }; | ||
|
|
||
| var dto = product.Adapt<ProductDTO>(); | ||
|
|
||
| dto.ShouldNotBeNull(); | ||
| dto.Id.ShouldEqual(product.Id); | ||
| } | ||
|
|
||
| [Test] | ||
| public void Adapt_With_Destination_Type_And_Config_Succeeds() | ||
| { | ||
| var config = new TypeAdapterConfig(); | ||
| config.ForType<Product, ProductDTO>(); | ||
|
|
||
|
|
||
| var product = new Product { Id = Guid.NewGuid(), Title = "ProductA", CreatedUser = new User { Name = "UserA" } }; | ||
|
|
||
| var dto = product.Adapt<ProductDTO>(config); | ||
|
|
||
| dto.ShouldNotBeNull(); | ||
| dto.Id.ShouldEqual(product.Id); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -312,6 +312,9 @@ internal TypeAdapterSettings GetMergedSettings(Type sourceType, Type destination | |
| { | ||
| if (this.RequireExplicitMapping && mapType != MapType.InlineMap && !MapContext.HasContext) | ||
| { | ||
| if(sourceType.) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess you did not intend to add this line. This PR is cool except this line, please remove. |
||
|
|
||
|
|
||
| if (!this.Dict.ContainsKey(new TypeTuple(sourceType, destinationType))) | ||
| throw new InvalidOperationException( | ||
| $"Implicit mapping is not allowed (check GlobalSettings.RequireExplicitMapping) and no configuration exists for the following mapping: TSource: {sourceType} TDestination: {destinationType}"); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool idea.