msan: update motd message for developer use + clang 21/22 + curl instrumentation#823
Conversation
|
I've received some feedback on what to improve here. Hence draft again for a short while. |
grooverdan
force-pushed
the
msan_update_motd
branch
from
4f904a1 to
4bb4892
Compare
|
There was interest in MDEV-20377 for a clang 21 /22 version. Added these with a small change to the idn2 build. With the server built on openssl the gnutls is limited to the C/C component and the change of build seemed to run tests normally. I wouldn't expect any change in the protect branch builder. Local tests hit no compile or mtr test failure. |
grooverdan
changed the title
dr-m
left a comment
dr-m
left a comment
There was a problem hiding this comment.
Looks good, except I think that it could be good to keep the note about disabling liburing in some form. If the image does not include liburing-dev, then that mention can be omitted. (Hopefully the image does include libaio-dev, so that the asynchronous code path will be covered.)
grooverdan
force-pushed
the
msan_update_motd
branch
from
4bb4892 to
950ac68
Compare
Until MariaDB/server#4257 is merged up lets keep the motd slightly conservative.
grooverdan
force-pushed
the
msan_update_motd
branch
2 times, most recently
from
7363741 to
3687d14
Compare
grooverdan
force-pushed
the
msan_update_motd
branch
from
3687d14 to
24321b1
Compare
| -DWITH_INNODB_{BZIP2,LZ4,LZMA,LZO,SNAPPY}=OFF \ | ||
| -DCMAKE_DISABLE_FIND_PACKAGE_URING=1 \ |
There was a problem hiding this comment.
These instructions are specific to this container, right? If the -dev packages of the various compression libraries are missing from the container, then there should be no need to disable them, right?
Furthermore, thanks to MariaDB/server#4257, there should be no reason to disable the use of liburing-dev (which I think you wrote would be included in the container image).
There was a problem hiding this comment.
yep:
-- The following OPTIONAL packages have not been found:
* BZip2
* LZ4 (required version >= 1.6)
* LibLZMA
* LZO
* Snappy
Out of tree build cannot build on read only source directory
|
@RazvanLiviuVarzaru this is ready to merge now. |
This enables MSAN s3 tests to function correctly.
grooverdan
changed the title
3 participants
The cmake command wasn't copy/pasteable with trailing space after \ and getting though Docker + shell escaping to produce a plain text file was awkwards.
HAVE_CXX_NEW=1 removed as its autodetected. Also the safemalloc in codebase isn't compiled under MSAN.
Added columnstore to disable as it insists on writing to the sourcedir. (read only). Also insufficient MTR tests around it mean its barely tested after compile.