Skip to content

Create GOVERNANCE.md - #1680

Open
kajarnocom wants to merge 1 commit into
MariaDB:10.6from
kajarnocom:patch-2
Open

Create GOVERNANCE.md#1680
kajarnocom wants to merge 1 commit into
MariaDB:10.6from
kajarnocom:patch-2

Conversation

@kajarnocom

Copy link
Copy Markdown

Initial content, with pointers to two sub-files – to reside in the governance/ subdirectory

Initial content, with pointers to two sub-files – to reside in the governance/ subdirectory
@ericherman

Copy link
Copy Markdown
Contributor

Nice to see such a quick response to https://jira.mariadb.org/browse/MDEV-23951

There is an existing "Docs" directory, but I think a new "governance" directory for the supporting "Foundation_bylaws.md" and "Board_Member_expectations.md" would also be good.

@an3l an3l self-assigned this Oct 14, 2020
@an3l an3l added this to the 10.6 milestone Oct 14, 2020
@ottok

ottok commented Oct 14, 2020

Copy link
Copy Markdown
Contributor

Related: Github has built-in support for CODEOWNERS, a file where you can define "governance" in the sense that who is expected to be responsible for that parts of the codebase, and who will by default be the suggested reviewer for changes to files in those paths. See https://github.com/MariaDB/server/pull/1650/files

@ottok

ottok commented Oct 14, 2020

Copy link
Copy Markdown
Contributor

See also: https://docs.github.com/en/free-pro-team@latest/github/building-a-strong-community/setting-up-your-project-for-healthy-contributions

There are certain magic files, such as CONTRIBUTING, CODE_OF_CONDUCT, SUPPORT, FUNDING, SECURITY etc (in addition the CODEOWNERS mentioned above).

@robertbindar

Copy link
Copy Markdown
Contributor

Related: Github has built-in support for CODEOWNERS, a file where you can define "governance" in the sense that who is expected to be responsible for that parts of the codebase, and who will by default be the suggested reviewer for changes to files in those paths. See https://github.com/MariaDB/server/pull/1650/files

Hi @ottok and thanks for pushing for this, I believe it is really important to use GitHub at its full potential for our repositories. I think this is out of scope for this PR, but there is an ongoing effort to introduce the magic files you mentioned above and also to offer some more Markdown love to our server/ repository, stay tuned.

@an3l an3l mentioned this pull request Apr 26, 2021
@LinuxJedi

Copy link
Copy Markdown
Contributor

So that we can get the communication in the PR moving again and come to a resolution for it.

@ottok and @kajarnocom do we think the solution for this particular PR is to rename this file CODEOWNERS.md and potentially add stub files that for now can just say "coming soon" or something in the governance directory until that can be contributed in a separate PR?

I'm happy to make this change and put it into 10.11 if we are in agreement. We can then work on the content of the other files if it does not already exist.

@ericherman

ericherman commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

Hello @LinuxJedi !

I would not use the name CODEOWNERS.md for anything that is not a file in the format expected by GitHub.

I believe that a CODEOWNERS file covers expertise of committers rather than codebase or project "governance".

Yes, a committer process which automatically requests reviews from the experts on particular files is great, but not the same scope as codebase/project governance.

As such, I'd suggest that it would be better to move this forward by making a separate MDEV for CODEOWNERS support, rather than expand the scope of MDEV-23951 and this PR.

Perhaps worth considering is that the CNF Graduation Criteria clearly distinguishes these two related concepts:

Explicitly define a project governance and committer process. The committer process should cover the full committer lifecycle including onboarding and offboarding or emeritus criteria. This preferably is laid out in a GOVERNANCE.md file and references an OWNERS.md file showing the current and emeritus committers.

Regardless, I like your proposal to build the related parts up incrementally -- perhaps including stub files -- and moving this forward again.

@an3l an3l removed their assignment Mar 28, 2023
@cvicentiu cvicentiu added External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements. MariaDB Foundation Pull requests created by MariaDB Foundation and removed External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements. labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MariaDB Foundation Pull requests created by MariaDB Foundation

Development

Successfully merging this pull request may close these issues.

7 participants