MDEV-12192 Shell-style alias/unalias commands for MariaDB client - #2341
Open
an3l wants to merge 16 commits into
Open
MDEV-12192 Shell-style alias/unalias commands for MariaDB client#2341an3l wants to merge 16 commits into
an3l wants to merge 16 commits into
Conversation
an3l
force-pushed
the
bb-10.3-anel-alias-MDEV-12192-v3
branch
2 times, most recently
from
November 28, 2022 16:11
cb5190f to
ff287b2
Compare
- Apply svoj review of PR MariaDB#301 - Update error message
- Alias buffer in `com_go()` should be used if an alias exist, otherwise all other queries will break. The same should happen with collations. - Check memory allocations for alias name/value - Style fixes - Add test case and result
- Remove initialization of mariadbrc file from `init_alias()` - Further style fixes
… shortcut command - Check which buffer to use as an argument for the call to the function pointer of command. Buffer shouldn't have delimiter. - By default check if command processed is `go` which doesn't take any parameter (`takes_params`) or if a server side comment (`/*! \C latin1 */ select 1`) is applied. If so use `pos` buffer, otherwise create buffer without delimiter. - Order of call of function pointer matters.
an3l
force-pushed
the
bb-10.3-anel-alias-MDEV-12192-v3
branch
from
March 13, 2024 09:01
ff287b2 to
66c18e4
Compare
Contributor
|
@svoj https://jira.mariadb.org/browse/MDEV-12192 is assigned to you, so assigning you this PR. You can close if it's no longer useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.