MDEV-24602: Cannot specify a name for a column check constraint by an3l · Pull Request #2773 · MariaDB/server

an3l · 2023-09-28T14:38:23Z

Adding parser rule for named constraint
Add checks of names for field check constraints and between field and
table check constraints (table check constraints name checks are done in
mysql_prepare_create)
When altering/modifying table with field/table constraints check field/table
constraints for adding constraint make it possible by changes done in
parser, what is inline with documentation

alter_specification:
MODIFY [COLUMN] [IF EXISTS] col_name column_definition
[FIRST | AFTER col_name]

Fixes: MDEV-24598: duplicate CHECK constraint name
Includes reverting MDEV-16630
Reviewer: <>

vuvova · 2023-09-30T14:16:59Z

  `b` char(1) DEFAULT NULL,
  PRIMARY KEY (`a`),
  KEY `b` (`new_b`),
+  CONSTRAINT `CONSTRAINT_1` CHECK (`a` + `new_b` > 0),


I don't understand. Why did you change how constraints are printed?

Because of mysqldump that uses show create table and added constraint for json_valid that for the test mysqldump.test returned duplicate error constraint (duplicating when dumping mysql.global_priv table).

for what table/test there was a duplicate error constraint? why?

Have updated with the new commit as well PR description with questions and problems for the patch.

The patch should be functional - no problems for the patch :).

vuvova

See inline comments. Global comments:

please put MDEV-24602 and MDEV-24598 in two different commits. They could still be in the same PR, just different commits.
in MDEV-24598 you need to handle the case when an existing table (created before your fix) has duplicate constraint names. What will happen in this case? Will ALTER TABLE work?

vuvova · 2024-01-15T13:10:15Z

+          packet->append(STRING_WITH_LEN(" CONSTRAINT "));
+          packet->append(field->check_constraint->name.str);
+        }
+      }


Why is that?

In case of create or alter table with new constraint name, there is no visible constraint name in show create.
Like:

`t0` int(11) DEFAULT NULL, `t1` int(11) DEFAULT NULL CHECK (`t1` > 0), `t2` int(11) DEFAULT NULL CHECK (`t2` > 0), - `t3` int(11) DEFAULT NULL CHECK (`t3` > 0) + `t3` int(11) DEFAULT NULL CONSTRAINT t_field CHECK (`t3` > 0) ) ENGINE=MyISAM DEFAULT CHARSET=latin1 COLLATE=latin1_swedish_ci SELECT CONSTRAINT_NAME, TABLE_NAME, CONSTRAINT_TYPE FROM information_schema.TABLE_CONSTRAINTS WHERE @@ -408,7 +408,7 @@ show create table t; Table Create Table t CREATE TABLE `t` ( - `t1` int(11) DEFAULT NULL CHECK (`t1` > 3.14) + `t1` int(11) DEFAULT NULL CONSTRAINT t1_greater_pi_check CHECK (`t1` > 3.14) ) ENGINE=MyISAM DEFAULT CHARSET=latin1 COLLATE=latin1_swedish_ci SELECT * from INFORMATION_SCHEMA.CHECK_CONSTRAINTS WHERE CONSTRAINT_SCHEMA = 'test';

vuvova · 2024-01-15T13:10:18Z

+            $$= $1;
+            $$->check_constraint= $3;
+            $$->check_constraint->name= $2;
+          }


please, rebase your PR to 10.5. I suspect this hunk might be a problem there.

Yes, seems there are some problems with 10.5. ⚒️
Update: Here is the rebased version of this PR for 10.5 https://github.com/an3l/server/commits/bb-10.5-anel-MDEV-24602-field-constraint-v5/

…ches table name" This reverts commit 8639e28.

- Name of the field check constraint is the same as the name of the field. - Add check of field name and table constraint names, that is done during `mysql_prepare_create_table()` - Closes PR MariaDB#2773 - Reviewer: <>

- `ALTER TABLE MODIFY_SYM` should use `column_def` instead of `field_spec` what is inline with documentation ``` alter_specification: MODIFY [COLUMN] [IF EXISTS] col_name column_definition [FIRST | AFTER col_name] ``` - Closes PR MariaDB#2773 -Reviewer: <>

- Adding parser rule for named constraint - Closes PR MariaDB#2773 - Reviewer: <>

- Name of the field check constraint is the same as the name of the field. - Add check of field name and table constraint names, that is done during `mysql_prepare_create_table()` - Closes PR MariaDB#2773 - Reviewer: <>

- `ALTER TABLE MODIFY_SYM` should use `column_def` instead of `field_spec` what is inline with documentation ``` alter_specification: MODIFY [COLUMN] [IF EXISTS] col_name column_definition [FIRST | AFTER col_name] ``` - Closes PR MariaDB#2773 -Reviewer: <>

- Adding parser rule for named constraint - Closes PR MariaDB#2773 - Reviewer: <>

- Name of the field check constraint is the same as the name of the field. - Add check of field name and table constraint names, that is done during `mysql_prepare_create_table()` - Closes PR MariaDB#2773 - Reviewer: <>

- `ALTER TABLE MODIFY_SYM` should use `column_def` instead of `field_spec` what is inline with documentation ``` alter_specification: MODIFY [COLUMN] [IF EXISTS] col_name column_definition [FIRST | AFTER col_name] ``` - Closes PR MariaDB#2773 -Reviewer: <>

- Adding parser rule for named constraint - Closes PR MariaDB#2773 - Reviewer: <>

an3l added the MariaDB Foundation Pull requests created by MariaDB Foundation label Sep 28, 2023

an3l added this to the 10.4 milestone Sep 28, 2023

an3l requested a review from vuvova September 28, 2023 14:38

an3l assigned vuvova Sep 28, 2023

an3l changed the title ~~MDEV-24602: Cannot specify a name for a column check constraint~~ WIP: MDEV-24602: Cannot specify a name for a column check constraint Sep 28, 2023

an3l force-pushed the bb-10.4-anel-MDEV-24602-field-constraint branch from d7c8188 to 6ed55d0 Compare September 29, 2023 09:33

vuvova reviewed Sep 30, 2023

View reviewed changes

an3l force-pushed the bb-10.4-anel-MDEV-24602-field-constraint branch 2 times, most recently from 1fb93f6 to efeb4b6 Compare October 25, 2023 15:01

an3l changed the title ~~WIP: MDEV-24602: Cannot specify a name for a column check constraint~~ MDEV-24602: Cannot specify a name for a column check constraint Oct 25, 2023

an3l force-pushed the bb-10.4-anel-MDEV-24602-field-constraint branch 2 times, most recently from ffb2f87 to 73b7130 Compare October 26, 2023 17:53

vuvova requested changes Jan 15, 2024

View reviewed changes

an3l added 5 commits January 29, 2024 09:04

Add const field and const function member has_default_expression

f0d8ddc

Revert "MDEV-16630: Ambiguous error message when check constraint mat…

f0f5c45

…ches table name" This reverts commit 8639e28.

MDEV-24598: duplicate CHECK constraint name

ffd3ae2

- Name of the field check constraint is the same as the name of the field. - Add check of field name and table constraint names, that is done during `mysql_prepare_create_table()` - Closes PR MariaDB#2773 - Reviewer: <>

MDEV-24602: Cannot specify a name for a column check constraint

6bfbba8

- Adding parser rule for named constraint - Closes PR MariaDB#2773 - Reviewer: <>

an3l force-pushed the bb-10.4-anel-MDEV-24602-field-constraint branch from 73b7130 to 6bfbba8 Compare January 29, 2024 12:41

an3l added a commit to an3l/server that referenced this pull request Jan 29, 2024

MDEV-24602: Cannot specify a name for a column check constraint

4cff1da

- Adding parser rule for named constraint - Closes PR MariaDB#2773 - Reviewer: <>

an3l added a commit to an3l/server that referenced this pull request Jan 29, 2024

MDEV-24602: Cannot specify a name for a column check constraint

4be4d18

- Adding parser rule for named constraint - Closes PR MariaDB#2773 - Reviewer: <>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

MDEV-24602: Cannot specify a name for a column check constraint - #2773

MDEV-24602: Cannot specify a name for a column check constraint#2773
an3l wants to merge 5 commits into
MariaDB:10.4from
an3l:bb-10.4-anel-MDEV-24602-field-constraint

an3l commented Sep 28, 2023 •

edited

Loading

Uh oh!

vuvova Sep 30, 2023

Uh oh!

an3l Oct 2, 2023

Uh oh!

vuvova Oct 9, 2023

Uh oh!

an3l Oct 19, 2023

Uh oh!

an3l Nov 16, 2023

Uh oh!

vuvova left a comment

Uh oh!

vuvova Jan 15, 2024

Uh oh!

an3l Jan 29, 2024 •

edited

Loading

Uh oh!

vuvova Jan 15, 2024

Uh oh!

an3l Jan 29, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

an3l commented Sep 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vuvova Sep 30, 2023

Choose a reason for hiding this comment

Uh oh!

an3l Oct 2, 2023

Choose a reason for hiding this comment

Uh oh!

vuvova Oct 9, 2023

Choose a reason for hiding this comment

Uh oh!

an3l Oct 19, 2023

Choose a reason for hiding this comment

Uh oh!

an3l Nov 16, 2023

Choose a reason for hiding this comment

Uh oh!

vuvova left a comment

Choose a reason for hiding this comment

Uh oh!

vuvova Jan 15, 2024

Choose a reason for hiding this comment

Uh oh!

an3l Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vuvova Jan 15, 2024

Choose a reason for hiding this comment

Uh oh!

an3l Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

an3l commented Sep 28, 2023 •

edited

Loading

an3l Jan 29, 2024 •

edited

Loading

an3l Jan 29, 2024 •

edited

Loading