Skip to content

MDEV-33420: HASHICORP_KEY_MANAGEMENT fails on Windows with libcurl installed - #3068

Closed
an3l wants to merge 1 commit into
MariaDB:11.4from
an3l:bb-11.4-anel-MDEV-33420-hashicorp-windows
Closed

MDEV-33420: HASHICORP_KEY_MANAGEMENT fails on Windows with libcurl installed#3068
an3l wants to merge 1 commit into
MariaDB:11.4from
an3l:bb-11.4-anel-MDEV-33420-hashicorp-windows

Conversation

@an3l

@an3l an3l commented Feb 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Basing the PR against the correct MariaDB version

  • This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@an3l an3l added the MariaDB Foundation Pull requests created by MariaDB Foundation label Feb 15, 2024
@an3l an3l added this to the 11.4 milestone Feb 15, 2024
@an3l
an3l requested a review from sysprg February 15, 2024 14:30
an3l added a commit to an3l/server that referenced this pull request Feb 15, 2024
@an3l
MDEV-33420: HASHICORP_KEY_MANAGEMENT fails on Windows with libcurl in…
18ee808 
…stalled

- When libcurl is installed in path out of default path, like on
Windows, `include_directories` failed to find `curl/curl.h`.
- Fix cmake by using modern syntax with imported target and
`find_package`
- Fix warnings treated as the errors
- Add package to Server component in Windows
- Closes PR MariaDB#3068
- Reviewer: <>
@an3l
an3l force-pushed the bb-11.4-anel-MDEV-33420-hashicorp-windows branch from 45938d5 to 18ee808 Compare February 15, 2024 15:54
an3l added a commit to an3l/server that referenced this pull request Feb 15, 2024
@an3l
MDEV-33420: HASHICORP_KEY_MANAGEMENT fails on Windows with libcurl in…
7273389 
…stalled

- When libcurl is installed in path out of default path, like on
Windows, `include_directories` failed to find `curl/curl.h`.
- Fix cmake by using modern syntax with imported target and
`find_package`
- Fix warnings treated as the errors
- Add package to Server component in Windows
- Closes PR MariaDB#3068
- Reviewer: <wlad@mariadb.com>
@an3l
an3l requested a review from vaintroub February 15, 2024 15:58
@an3l
an3l force-pushed the bb-11.4-anel-MDEV-33420-hashicorp-windows branch from 18ee808 to 7273389 Compare February 15, 2024 15:58
an3l added a commit to an3l/server that referenced this pull request Feb 16, 2024
@an3l
MDEV-33420: HASHICORP_KEY_MANAGEMENT fails on Windows with libcurl in…
3fb4b9d 
…stalled

- When libcurl is installed in path out of default path, like on
Windows, `include_directories` failed to find `curl/curl.h`.
- Fix cmake by using modern syntax with imported target and
`find_package`
- Fix warnings treated as the errors
  - Remove `HASHICORP_HAVE_EXCEPTIONS` macro and related code
- Add package to Server component in Windows
- Closes PR MariaDB#3068
- Reviewer: <wlad@mariadb.com>
@an3l
an3l force-pushed the bb-11.4-anel-MDEV-33420-hashicorp-windows branch from 7273389 to 3fb4b9d Compare February 16, 2024 16:21
vaintroub
vaintroub approved these changes Feb 16, 2024
View reviewed changes

@vaintroub vaintroub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

an3l added a commit to an3l/server that referenced this pull request Mar 7, 2024
@an3l
MDEV-33420: HASHICORP_KEY_MANAGEMENT fails on Windows with libcurl in…
be64dd3 
…stalled

- When libcurl is installed in path out of default path, like on
Windows, `include_directories` failed to find `curl/curl.h`.
- Fix cmake by using modern syntax with imported target and
`find_package`
- Fix warnings treated as the errors
  - Remove `HASHICORP_HAVE_EXCEPTIONS` macro and related code
- Add package to Server component in Windows
- Closes PR MariaDB#3068
- Reviewer: <wlad@mariadb.com>
@an3l
an3l force-pushed the bb-11.4-anel-MDEV-33420-hashicorp-windows branch from 3fb4b9d to be64dd3 Compare March 7, 2024 09:37
an3l added a commit to an3l/server that referenced this pull request Mar 7, 2024
@an3l
MDEV-33420: HASHICORP_KEY_MANAGEMENT fails on Windows with libcurl in…
f68083d 
…stalled

- When libcurl is installed in path out of default path, like on
Windows, `include_directories` failed to find `curl/curl.h`.
- Fix cmake by using modern syntax with imported target and
`find_package`
- Fix warnings treated as the errors
  - Remove `HASHICORP_HAVE_EXCEPTIONS` macro and related code
- Add package to Server component in Windows
- Closes PR MariaDB#3068
- Reviewer: <wlad@mariadb.com>
@an3l an3l mentioned this pull request Mar 7, 2024
Open
4 tasks
an3l added a commit to an3l/server that referenced this pull request Apr 12, 2024
@an3l
MDEV-33420: HASHICORP_KEY_MANAGEMENT fails on Windows with libcurl in…
e11fc3f 
…stalled

- When `libcurl` is installed in path out of default path, like on
Windows, `include_directories` failed to find `curl/curl.h`.
- Fix `cmake` by using modern syntax with imported target and
`find_package`
- Fix warnings treated as the errors
  - Remove `HASHICORP_HAVE_EXCEPTIONS` macro and related code
- Add package to `Server` component in Windows
- Tested with `$ ./mysql-test/mtr --suite=vault`
- Closes PR MariaDB#3068
- Reviewer: <wlad@mariadb.com>
            <julius.goryavsky@mariadb.com>
@an3l
an3l force-pushed the bb-11.4-anel-MDEV-33420-hashicorp-windows branch from ee7c438 to e11fc3f Compare April 12, 2024 07:00
@CLAassistant

CLAassistant commented Apr 12, 2024 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@an3l
an3l changed the base branch from 11.4 to 10.11 April 12, 2024 07:05
sysprg pushed a commit that referenced this pull request Apr 17, 2024
@an3l @sysprg
MDEV-33420: HASHICORP_KEY_MANAGEMENT fails on Windows with libcurl in…
11aeef2 
…stalled

- When `libcurl` is installed in path out of default path, like on
Windows, `include_directories` failed to find `curl/curl.h`.
- Fix `cmake` by using modern syntax with imported target and
`find_package`
- Fix warnings treated as the errors
  - Remove `HASHICORP_HAVE_EXCEPTIONS` macro and related code
- Add package to `Server` component in Windows
- Tested with `$ ./mysql-test/mtr --suite=vault`
- Closes PR #3068
- Reviewer: <wlad@mariadb.com>
            <julius.goryavsky@mariadb.com>
@an3l
MDEV-33420: HASHICORP_KEY_MANAGEMENT fails on Windows with libcurl in…
6a07769 
…stalled

- When `libcurl` is installed in path out of default path, like on
Windows, `include_directories` failed to find `curl/curl.h`.
- Fix `cmake` by using modern syntax with imported target and
`find_package`
- Fix warnings treated as the errors
  - Remove `HASHICORP_HAVE_EXCEPTIONS` macro and related code
- Add package to `Server` component in Windows
- Tested with `$ ./mysql-test/mtr --suite=vault`
- Closes PR MariaDB#3068
- Reviewer: <wlad@mariadb.com>
            <julius.goryavsky@mariadb.com>
@an3l
an3l force-pushed the bb-11.4-anel-MDEV-33420-hashicorp-windows branch from e11fc3f to 6a07769 Compare April 18, 2024 09:38
@an3l
an3l changed the base branch from 10.11 to 11.4 April 18, 2024 09:39
sysprg
sysprg approved these changes Apr 18, 2024
View reviewed changes

@sysprg sysprg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, merged with head revision as 11aeef2

@sysprg

sysprg commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

Thank you, PR merged with head revision as: 11aeef2

@sysprg sysprg closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaintroub vaintroub vaintroub approved these changes
+1 more reviewer
@sysprg sysprg sysprg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@sysprg sysprg

Labels

MariaDB Foundation Pull requests created by MariaDB Foundation

Milestone

11.4

Development

Successfully merging this pull request may close these issues.

4 participants

@an3l @CLAassistant @sysprg @vaintroub