Skip to content

MDEV-30645 - Implement generalized triggers 2 - #3551

Closed
andremralves wants to merge 1 commit into
MariaDB:mainfrom
andremralves:gen_trigger
Closed

MDEV-30645 - Implement generalized triggers 2#3551
andremralves wants to merge 1 commit into
MariaDB:mainfrom
andremralves:gen_trigger

Conversation

@andremralves

Copy link
Copy Markdown
Contributor
  • The Jira issue number for this PR is: MDEV-______

Description

Another approach for the implementation of Generalized Triggers with DROP TRIGGER ... ON ALL SERVER.

Release Notes

TODO: What should the release notes say about this change?
Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing.

How can this PR be tested?

TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended.
Consult the documentation on "Writing good test cases".

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@andremralves
andremralves force-pushed the gen_trigger branch 2 times, most recently from 8211a6a to 13829a7 Compare September 25, 2024 18:49
@andremralves
andremralves marked this pull request as ready for review October 7, 2024 02:09
@vuvova
vuvova self-requested a review October 7, 2024 08:58
@cvicentiu cvicentiu added the External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements. label Nov 26, 2024
@svoj svoj changed the title Implement generalized triggers 2 MDEV-36006 - Implement generalized triggers 2 Feb 1, 2025
@vuvova vuvova changed the title MDEV-36006 - Implement generalized triggers 2 MDEV-30645 - Implement generalized triggers 2 Feb 6, 2025
@vuvova vuvova added the GSoC label Jul 16, 2025
@gkodinov gkodinov added the Rework pull requests that are currently being re-implemented by the MariaDB developers label Mar 20, 2026

@gkodinov gkodinov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a preliminary review.
Please add a message compliant with the MariaDB coding standards to the commit. Also, please rebase on the latest main branch. And make sure all of the tests on all buildbot hosts are not failing because of your change.

@gkodinov gkodinov self-assigned this May 28, 2026
@gkodinov gkodinov removed the Rework pull requests that are currently being re-implemented by the MariaDB developers label May 28, 2026
@vuvova

vuvova commented May 28, 2026

Copy link
Copy Markdown
Member

@gkodinov, eh, no sorry. Please ask @dmitryshulga for the status of this work.

@gkodinov

Copy link
Copy Markdown
Member

@vuvova, there's been no activity known to me or confirmed by anybody on this PR. @dmitryshulga included. I'm converting this to a draft pull request. Please re-open when/if the work on this resumes.

@gkodinov
gkodinov marked this pull request as draft June 18, 2026 10:25
@vuvova

vuvova commented Jun 19, 2026

Copy link
Copy Markdown
Member

Thanks! The work was continued in #5034 by @dmitryshulga.

@vuvova vuvova closed this Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

External Contribution All PRs from entities outside of MariaDB Foundation, Corporation, Codership agreements. GSoC

Development

Successfully merging this pull request may close these issues.

4 participants