MDEV-35190 HASH_SEARCH duplicates effort before HASH_INSERT or HASH_DELETE

[dr-m]

This supercedes #3593, which was accidentally closed and can’t be resurrected.

• The Jira issue number for this PR is: MDEV-35190 and MDEV-35247

Description

The HASH_ macros are unnecessarily obfuscating the logic, so we had better replace them.

hash_cell_t::remove(): Implement most of the HASH_DELETE logic. This is based on buf_pool_t::page_hash_table::remove().

xb_filter_hash_free(): Avoid any hash table lookup; just traverse the hash bucket chains and free each element.

rm_if_not_found(): Make use of find_filter_in_hashtable().

dict_sys_t::acquire_temporary_table(), dict_sys_t::find_table(): Define non-inline to avoid unnecessary code duplication.

dict_sys_t::add(dict_table_t *table), dict_table_rename_in_cache(): Look for duplicate while finding the insert position.

dict_table_change_id_in_cache(): Merged to the only caller row_discard_tablespace().

hash_insert(): Helper function of dict_sys_t::resize().

fil_space_t::create(): Look for a duplicate (and crash if found) when searching for the insert position.

lock_rec_discard(): Take the hash array cell as a parameter to avoid a duplicated lookup.

lock_rec_free_all_from_discard_page(): Remove a parameter.

ut_fold_ull(): For SIZEOF_SIZE_T < 8, we simulate universal hashing (Carter and Wegman, 1977) by pretending that SIZE_T_MAX + 1 is a prime. In other words, we implement a Rabin–Karp rolling hash algorithm similar to java.lang.String.hashCode(). This is used for representing 64-bit dict_index_t::id or dict_table_t::id in the native word size.

If SIZEOF_SIZE_T >= 8, we just use an identity mapping instead of ut_fold_ull().

ut_hash_ulint(): Remove. The exclusive OR before a modulus operation does not serve any useful purpose; it is only obfuscating and wasting some code. mysql/mysql-server@b11a175 included a similar change.

Release Notes

Some InnoDB hash table operations were simplified to slightly improve performance.

How can this PR be tested?

This low level code should be well covered by the regression test suite. Some additional performance and stress testing would be helpful.

Basing the PR against the correct MariaDB version

• This is a new feature or a refactoring, and the PR is based against the main branch.
• This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

This depends on #3584 which was merged to 10.6.

PR quality check

• I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
• For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[mariadb-DebarunBanerjee]

Thanks @dr-m for keeping the hash table abstraction and still keeping the refactoring scope limited. Looks good to me.