MDEV-35472 Server crash in ha_storage_put_memlim upon reading from INNODB_LOCKS - #3649
Merged
Conversation
|
|
dr-m
force-pushed
the
10.6-MDEV-35472
branch
from
November 25, 2024 06:51
6877b9c to
ac793f7
Compare
mariadb-DebarunBanerjee
approved these changes
Nov 25, 2024
…NODB_LOCKS ha_storage_put_memlim(): Initialize node->next in order to avoid a crash on a subsequent invocation, due to dereferencing an uninitialized pointer. This fixes a regression that had been introduced in commit ccb6cd8 (MDEV-35189). Reviewed by: Debarun Banerjee
dr-m
force-pushed
the
10.6-MDEV-35472
branch
from
November 25, 2024 08:32
ac793f7 to
2255be0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ha_storage_put_memlim(): Initialize node->next in order to avoid a crash on a subsequent invocation, due to dereferencing an uninitialized pointer.
This fixes a regression that had been introduced in #3584 (MDEV-35189).
Release Notes
Because the bug is being fixed in the same releases that introduce it, no mention is needed.
How can this PR be tested?
Apparently, this subsystem is badly covered by existing regression tests. It would be challenging to test this, because there is some rate-limiting of updates of the cache. This was tested with a small stress test using
cmake -DWITH_ASAN=ON.Basing the PR against the correct MariaDB version
mainbranch.PR quality check