Remove masked open_table_def - #613
Open
an3l wants to merge 1 commit into
Open
Conversation
cvicentiu
suggested changes
Feb 16, 2018
| if (!hton) | ||
| flags|= GTS_NOLOCK; | ||
|
|
||
| <<<<<<< 2232784f0094ae7e81f5033fe8f3499e15224fed |
Contributor
There was a problem hiding this comment.
You didn't actually resolve the conflicts here! Let's go through this together.
Contributor
There was a problem hiding this comment.
Also, your changes updated libmariadb submodule. That shouldn't happen. Let's do a git tutorial next time we talk.
an3l
force-pushed
the
patch_create_table
branch
from
February 21, 2018 23:57
6856e38 to
0f1aba8
Compare
|
Can one of the admins verify this patch? |
|
|
LinuxJedi
added
the
MariaDB Foundation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In debugger, when "b my_message_sql" is used, when creating a new table (that doesn't exists) an error is raised, which is later ignored. This patch tries to prevent raising that error if we are in discovery mode.