Emails are wrongly validated as links

[jovyntls]

Tell us about your environment
MacOS Monterey 12.0.1

• MarkBind Version: v3.1.1

What did you do? Please include the actual source code causing the issue.
Place emails in any markdown file, e.g.:

email@gmail.com
student@u.nus.edu
with.dot@mail.sg

What did you expect to happen?
The emails should not be logged as warnings for invalid intralinks.

What actually happened? Please include the actual, raw output.

The email is prepended with a filepath (e.g. userGuide/mailto:), which is confusing since this prefix does not appear in the source files at all, and doing a search on userGuide/mailto:email@gmail.com will not give any results for an author trying to find where the invalid link is.

This is because convertRelativeLinks is called on all links, including emails, so a filepath is prepended onto emails.
I think a possible fix would be to check for emails (conveniently, they can be identified by a mailto: prefix) and not convert them to relative links, and possibly exclude them from validateIntralink calls.

[tlylt]

I think excluding it altogether would be gd(don't think there's any utility in validating an email address like that)

[ryoarmanda]

The email address, as it is a link, is contained as the href attribute of an <a> node. That prompts linkProcessor to do its job on trying to convert relative links from the attribute.

Currently we only have a select conditions that we use to "stop" the conversion, like if it's an URL, a hash, etc. Would be nice if we add a condition to filter out emails too as described.

[jonahtanjz]

Would also be good to account for phone numbers as well.

<a href="tel:91234567">mobile no.</a>

[tlylt]

@jovyntls May I check if #1819 addresses this issue? (also the part on phone numbers), if yes I think we can close this.

[jovyntls]

@jovyntls May I check if #1819 addresses this issue? (also the part on phone numbers), if yes I think we can close this.

Nope! Issue persists as #1819 moves the validation to the end of compiling all pages, but doesn't change the validation itself (mail: and tel: are still wrapped in <a> tags and hence validated as links).