Skip to content

Fix or simplify live reloading logic #2171

Description

@jovyntls

Referring to this line in Page/index.js:

    // Each source path will only contain 1 copy of build/re-build page (the latest one)
    pageVueServerRenderer.pageEntries[this.pageConfig.soucePath] = builtPage;

Because of a typo (sourcePath->soucePath), pageEntries in PageVueServerRenderer always only has one entry (with the key undefined). However, live reloading still seems to work: making changes to one or multiple Vue source files triggers live reload as expected. Same for md files. I haven't been able to find any unexpected behaviour caused by this line.

Instead of fixing the typo, I'm wondering if it's possible to remove this line entirely, or simplify the logic related to it?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions