PageNav cannot handle duplicate headings

[damithc]

v1.17.0

Problem: If a page has the same heading multiple times, PageNav shows only the first one.

[Chng-Zhi-Xuan]

Wouldn't this be expected behaviour?

Since the browser can only jump to one unique heading using the anchor. Even if I am able to index duplicate headings within the page navigation list, clicking on all of them will jump to the same one (first one).

[damithc]

Wouldn't this be expected behaviour?

Since the browser can only jump to one unique heading using the anchor. Even if I am able to index duplicate headings within the page navigation list, clicking on all of them will jump to the same one (first one).

From the implementation POV, yes. From the author's POV, why can't I have the same heading multiple times in the same page?

It seems this problem does not appear in normal pages where all the duplicate headings are in the same physical file (in which case duplicate headings have unique anchors suffixed with an index) but appears in complicated pages such as https://nus-te3201.github.io/2019/se-book-adapted/chapters/codeQuality.html. probably beause the content comes from many different files and rendered in a piecemeal fashion.

[Chng-Zhi-Xuan]

For any dynamically loaded content (Panels with src), page navigation is currently unable to index them. Comment in original PR.

This problem also extends beyond page navigation as same headings from different sources, loaded dynamically will share the same ID. So we would have to figure out a way to generate non-conflicting IDs for dynamic content.

[damithc]

I guess this is a hard problem to solve. :-p

[kaixin-hc]

I believe this might be fixed in the current markbind version, so I will close this issue:

Screen.Recording.2024-01-25.at.3.53.54.PM.mov