fontawsome icons don't show underlines to indicate modal/tooltip

[damithc]

v2.9.1

code:

<trigger trigger="click" for="modal:context-target">:fas-info:</trigger> 
<trigger trigger="click" for="modal:context-target">no icon</trigger> 

output:

problem: note how the underline is missing from the first trigger

[hcwong]

Hello Markbind peeps, can I take this?

[ang-zeyu]

Hello Markbind peeps, can I take this?

👍 Don't think anyone's working on this

[ang-zeyu]

Ignore the extra stuff earlier, could just do this with css.

Might check if it works for octicons though

[hcwong]

Hmmm I've changed Tooltip and trigger components: changing the underline style from text-decoration: underline dashed to border bottom: 1px dashed black (for standardization). Is this okay?

[ang-zeyu]

Sounds good; Might wanna try currentColor instead of black to keep the same underline color though

[damithc]

This feature seems to be broken again. See https://nus-cs2113-ay1920s2.github.io/website/admin/participation-dashboard.html

[hcwong]

@damithc is it the A0xxxxx values in the table?

[damithc]

@damithc is it the A0xxxxx values in the table?

Close. It's the ℹ️ icon that comes after the partial matric number. Clicking on it opens a modal, which means there should be a dotted line under it.

[hcwong]

I see, I tried finding the page on https://github.com/nus-cs2113-AY1920S2/website, but cant seem to find it. Is there anywhere I can find it to help debug (cos only the icon seems to be part of trigger, oddly)?