Restructure generated site data for searchbar ui#1006
Merged
Conversation
2fcd68f to
203637b
Compare
203637b to
c2f3d64
Compare
Contributor
Author
|
Rebased on latest, no conflicts |
marvinchin
approved these changes
Feb 8, 2020
Keywords tied to a heading are appended to the heading with a prepending '|' character. This is so that the '|' character would serve as a visual separator between the heading and the keyword. However, it is thus not possible to extract a keyword from its heading deterministically, as a heading can also include the '|' character. Let's move the keywords to its own field, allowing the searchbar to extract a heading's keyword from it.
c2f3d64 to
b714c19
Compare
Contributor
Author
|
Rebased on the latest master, no conflicts / changes otherwise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Enhancement to an existing feature
Resolves #994
Requires MarkBind/vue-strap#126 ( searchbar ui for vue-strap )
What is the rationale for this request?
Generated site data for the searchbar needs to be restructured to sift out the keywords from the heading deterministically.
What changes did you make? (Give an overview)
Generated site data:
headingsnow store only theid:'heading text...'pair instead ofid:'heading text... | concatenated keywords ...'headingKeywordsfieldconcatenateHeadingsAndKeywordswhich is no longer neededProvide some example code that this change will affect:
New site data:
Is there anything you'd like reviewers to focus on?
na
Testing instructions:
npm run testshould passProposed commit message: (wrap lines at 72 characters)
Restructure generated site data for searchbar ui
Keywords tied to a heading are appended to the heading with a prepending
'|' character.
This is so that the '|' character would serve as a visual separator
between the heading and the keyword.
However, it is thus not possible to extract a keyword from its heading
deterministically, as a heading can also include the '|' character.
Let's move the keywords to its own field, allowing the searchbar to
extract a heading's keyword from it.