Skip to content

Upgrade to bootstrap-vue 2.5.0#1085

Merged
yamgent merged 4 commits into
MarkBind:masterfrom
openorclose:update-bv
Mar 29, 2020
Merged

Upgrade to bootstrap-vue 2.5.0#1085
yamgent merged 4 commits into
MarkBind:masterfrom
openorclose:update-bv

Conversation

@openorclose

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• Enhancement to an existing feature

What is the rationale for this request?

Bootstrap-vue 2.5.0 has much better popovers and tooltips. They allow you to hover over the popover/tooltip and it won't disappear.

What changes did you make? (Give an overview)

Updated bootstrap-vue js and css

Provide some example code that this change will affect:

Is there anything you'd like reviewers to focus on?

Nothing else is broken

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)

@ang-zeyu

ang-zeyu commented Mar 4, 2020

Copy link
Copy Markdown
Contributor

The changelog dosen't seem to have breaking changes either.

The positioning still seems to be off for top/bottom though, as mentioned in #1033 (comment)
positioning

@openorclose

Copy link
Copy Markdown
Contributor Author

The changelog dosen't seem to have breaking changes either.

The positioning still seems to be off for top/bottom though, as mentioned in #1033 (comment)
positioning

Oh right, let me investigate

Comment thread package.json Outdated
@yamgent

yamgent commented Mar 15, 2020

Copy link
Copy Markdown
Member

Where did you obtain the min.js from? My copy of bootstrap-vue@2.5.0 does not match yours.

@openorclose

Copy link
Copy Markdown
Contributor Author

Where did you obtain the min.js from? My copy of bootstrap-vue@2.5.0 does not match yours.

I got it from https://unpkg.com/bootstrap-vue@2.5.0/dist/bootstrap-vue.min.js

@openorclose openorclose requested a review from marvinchin March 26, 2020 16:15
@marvinchin

Copy link
Copy Markdown
Contributor

Where did you obtain the min.js from? My copy of bootstrap-vue@2.5.0 does not match yours.

I got it from https://unpkg.com/bootstrap-vue@2.5.0/dist/bootstrap-vue.min.js

@yamgent is this good to go?

@yamgent yamgent added this to the v2.12.1 milestone Mar 29, 2020
@yamgent yamgent merged commit 4606143 into MarkBind:master Mar 29, 2020
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants