Skip to content

Update navbar doc#1146

Merged
yamgent merged 2 commits into
MarkBind:masterfrom
le0tan:issue-1113
Mar 29, 2020
Merged

Update navbar doc#1146
yamgent merged 2 commits into
MarkBind:masterfrom
le0tan:issue-1113

Conversation

@le0tan

@le0tan le0tan commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Documentation update

Closes #1113

@le0tan le0tan requested a review from nbriannl March 25, 2020 14:16

@nbriannl nbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think adding a short code snippet inside the tooltip to show how to do it i.e. <navbar type="primary" add-class="bg-info"> would help as well. What do you think?

@nbriannl nbriannl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yamgent yamgent added this to the v2.12.1 milestone Mar 29, 2020
@yamgent yamgent merged commit 7c78b77 into MarkBind:master Mar 29, 2020
marvinchin pushed a commit that referenced this pull request Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User Guide: Document more styling methods for NavBar

3 participants