Skip to content

Remove redundant and unused variables#1223

Merged
ang-zeyu merged 1 commit into
MarkBind:masterfrom
ang-zeyu:remove-redundant-variables
May 21, 2020
Merged

Remove redundant and unused variables#1223
ang-zeyu merged 1 commit into
MarkBind:masterfrom
ang-zeyu:remove-redundant-variables

Conversation

@ang-zeyu

@ang-zeyu ang-zeyu commented May 5, 2020

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [x] Other, please explain:

Resolves #1081
Resolves #1084 completely (many instances have already been slowly omitted between the time of the issue and now)

What is the rationale for this request?

  • Remove some redundant / unused variables

What changes did you make? (Give an overview)

  • Remove two remaining declarations of context.mode ( there aren't any usages )
  • Remove boilerplateIncludeSrc implementations, double checking both in code and manual testing that live reload still works with boilerplates

Proposed commit message: (wrap lines at 72 characters)
Remove redundant and unused variables

@ang-zeyu ang-zeyu requested a review from marvinchin May 20, 2020 12:56
@ang-zeyu ang-zeyu added this to the v2.15.0 milestone May 21, 2020
@ang-zeyu ang-zeyu merged commit 245eabb into MarkBind:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate removing context.mode completely Investigate removing boilerplateIncludeSrc

2 participants