Skip to content

Fix padding and font weight for custom list items#1254

Merged
ang-zeyu merged 1 commit into
MarkBind:masterfrom
ang-zeyu:fix-custom-sitenav-formatting
Jun 19, 2020
Merged

Fix padding and font weight for custom list items#1254
ang-zeyu merged 1 commit into
MarkBind:masterfrom
ang-zeyu:fix-custom-sitenav-formatting

Conversation

@ang-zeyu

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [x] Bug fix

Fixes #1249

What is the rationale for this request?
Simply adds the custom styles used for default list items to custom list items, doing some class renaming to better differentiate the two.

Testing instructions:
custom list classes should now get the font-weight and padding styling, but without the highlight-on-hover


Code:
Untitled


Output:
Untitled


Proposed commit message: (wrap lines at 72 characters)
Fix padding and font weight for custom list items

Padding and font weight formatting are not applied for custom list
items without nested lists or anchors.

Let's add these, and rename the classes used for better naming
consistency.

Padding and font weight formatting are not applied for custom list
items without nested lists or anchors.

Let's add these, and rename the classes used for better naming
consistency.
@ang-zeyu ang-zeyu force-pushed the fix-custom-sitenav-formatting branch from 92d9511 to 95be682 Compare June 19, 2020 12:11
@ang-zeyu

Copy link
Copy Markdown
Contributor Author

clean rebase above

@damithc I left the right padding as is, you could add it using the bootstrap classes easily though { .p-1/2/3/4/5 }, or overwrite the site-nav-custom-list-item class, sounds good?

@damithc

damithc commented Jun 19, 2020

Copy link
Copy Markdown
Contributor

@damithc I left the right padding as is, you could add it using the bootstrap classes easily though { .p-1/2/3/4/5 }, or overwrite the site-nav-custom-list-item class, sounds good?

Yes. Right-padding is not that important.

@ang-zeyu

Copy link
Copy Markdown
Contributor Author

Yes. Right-padding is not that important.

ok i'll merge this in then, since it hasn't been released and just shifts some styles around

@ang-zeyu ang-zeyu added this to the v2.15.0 milestone Jun 19, 2020
@ang-zeyu ang-zeyu merged commit c8feae4 into MarkBind:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SiteNav: formatting difference for linked and unlinked items

2 participants