Fix padding and font weight for custom list items#1254
Merged
Conversation
Padding and font weight formatting are not applied for custom list items without nested lists or anchors. Let's add these, and rename the classes used for better naming consistency.
92d9511 to
95be682
Compare
Contributor
Author
|
clean rebase above @damithc I left the right padding as is, you could add it using the bootstrap classes easily though |
Contributor
Yes. Right-padding is not that important. |
Contributor
Author
ok i'll merge this in then, since it hasn't been released and just shifts some styles around |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
Fixes #1249
What is the rationale for this request?
Simply adds the custom styles used for default list items to custom list items, doing some class renaming to better differentiate the two.
Testing instructions:
custom list classes should now get the font-weight and padding styling, but without the highlight-on-hover
Code:

Output:

Proposed commit message: (wrap lines at 72 characters)
Fix padding and font weight for custom list items
Padding and font weight formatting are not applied for custom list
items without nested lists or anchors.
Let's add these, and rename the classes used for better naming
consistency.