Restore colors to test output#1341
Merged
Merged
Conversation
ang-zeyu
force-pushed
the
restore-test-colors
branch
from
86b0aeb to
adf517a
Compare
Lerna run test executes the npm test script of each package in a subprocess, causing certain libraries like chalk to disable color output since stdout is not a TTY. Let's override this behavior, enabling color output for tests.
ang-zeyu
force-pushed
the
restore-test-colors
branch
from
63777d3 to
0007d8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix: restore colors for tests' tty output
What is the rationale for this request?
#1291 switched over to
lerna runfor tests, which causes colors to be lost from test output in some instances.What changes did you make? (Give an overview)
--colorstojestcommands (which use chalk under the hood) to force color output thereFORCE_COLORenv variable for chalk in our functional tests to force color output there as wellProposed commit message: (wrap lines at 72 characters)
Restore colors to test output
Lerna run test executes the npm test script of each package in a
subprocess, causing certain libraries like chalk to disable color
output since stdout is not a TTY.
Let's override this behavior, enabling color output for tests.