Make navigation menus accessible on smaller screens #1445
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| <template> | ||
| <div> | ||
| <span | ||
|
Contributor
There was a problem hiding this comment. suggestion: pull the icon upward using scoped slots, so the component specific styles can be moved up there not sure if it would end up more verbose though 😐
Contributor
Author
There was a problem hiding this comment. Shifted this up. Doesn't look too verbose :) |
||
| :class="[{ 'nav-menu-close-icon': show }]" | ||
| @click="toggleNavMenu" | ||
| > | ||
| <slot name="navMenuIcon"></slot> | ||
| </span> | ||
| <div ref="navMenuContainer" :class="['nav-menu', { 'nav-menu-open': show }]"> | ||
| <retriever | ||
| v-if="hasIdentifier" | ||
| :src="src" | ||
| :fragment="fragment" | ||
| @src-loaded="navMenuLoaded" | ||
| /> | ||
| <div v-else ref="navigationMenu"></div> | ||
| </div> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script> | ||
| import retriever from './Retriever.vue'; | ||
| import $ from './utils/NodeList'; | ||
| import { publish, subscribe } from './utils/pubsub'; | ||
|
|
||
| export default { | ||
| components: { | ||
| retriever, | ||
| }, | ||
| props: { | ||
| type: { | ||
| type: String, | ||
| default: null, | ||
| }, | ||
| src: { | ||
| type: String, | ||
| default: null, | ||
| }, | ||
| fragment: { | ||
| type: String, | ||
| default: null, | ||
| }, | ||
| hasIdentifier: { | ||
| type: Boolean, | ||
| default: false, | ||
| }, | ||
| getNavMenuContent: { | ||
| type: Function, | ||
| default: () => {}, | ||
| }, | ||
| }, | ||
| inject: ['toggleLowerNavbar'], | ||
| data() { | ||
| return { | ||
| show: false, | ||
| }; | ||
| }, | ||
| methods: { | ||
| toggleNavMenu() { | ||
| if (!this.show) { publish('closeOverlay'); } | ||
| this.show = !this.show; | ||
| }, | ||
| navMenuLoaded() { | ||
| this.toggleLowerNavbar(); | ||
| $(this.$refs.navMenuContainer).find('a').on('click', () => { | ||
| this.toggleNavMenu(); | ||
| }); | ||
| }, | ||
| }, | ||
| mounted() { | ||
| const navMenu = this.$refs.navigationMenu; | ||
| const buildNav = (navMenuItems) => { | ||
| if (!navMenuItems) { return; } | ||
| for (let i = 0; i < navMenuItems.childNodes.length; i += 1) { | ||
| navMenu.appendChild(navMenuItems.childNodes[i].cloneNode(true)); | ||
| } | ||
| this.navMenuLoaded(); | ||
| }; | ||
|
|
||
| if (!this.hasIdentifier) { | ||
| buildNav(this.getNavMenuContent()); | ||
| } | ||
|
|
||
| subscribe('closeOverlay', () => { this.show = false; }); | ||
| }, | ||
| }; | ||
| </script> | ||
|
|
||
| <style scoped> | ||
| .nav-menu { | ||
| display: none; | ||
| padding: 50px 10px 20px; | ||
| position: fixed; | ||
| overflow-y: auto; | ||
| z-index: -1; | ||
| } | ||
|
|
||
| .nav-menu-close-icon > span::before { | ||
| content: "\e014" !important; | ||
| } | ||
|
|
||
| .nav-menu-open { | ||
| display: block !important; | ||
| width: 100% !important; | ||
| background: #fff; | ||
| height: 100%; | ||
| clear: both; | ||
| } | ||
| </style> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor styling issue: (navbar example in ug)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Fixed :)