Enable linting for dropdown.vue#1462
Conversation
|
@ang-zeyu This PR is ready for review. Would appreciate if you can look through and give some feedbacks 😃 |
| padding: 0; | ||
| border: 0; | ||
| } | ||
| .secret { |
There was a problem hiding this comment.
looks good!
just one nit: let's enable and fix stylelint separately (for all .vue files that are es-linted)
There was a problem hiding this comment.
Sure 👍
Should I do it in this PR or open a separate one?
There was a problem hiding this comment.
let's do it separately, iirc none of the .vue files are validated in our ci tests - might be quite a few changes
There was a problem hiding this comment.
Alright. I've enabled stylelint for all .vue files but added all of them to .stylelintignore except for dropdown.vue for now. Will do it separately for all the other files in the next PR :)
|
|
||
| # --- packages/vue-components .vue files --- | ||
|
|
||
| packages/vue-components/src/Navbar.vue |
There was a problem hiding this comment.
meant to shift all of stylelint to another PR, so you wouldn't have to write this huge ignore list here 😅
but am fine with this as well.
There was a problem hiding this comment.
Enable linting for dropdown.vue
let's update the message body to highlight vue css lint enabling as well
There was a problem hiding this comment.
Thanks @ang-zeyu. Updated the message body.
2 participants
What is the purpose of this pull request?
Overview of changes:
This is a follow-up PR to #1455. Linting for
dropdown.vueis enabled and code is refactored to be consistent with the lint rules.Anything you'd like to highlight / discuss:
Previously, there is a
classwhich is set tonullin the props. Not sure what is the function of it as it seems to work fine after removal. If it is needed, will proceed to add it back.Testing instructions:
npm run testProposed commit message: (wrap lines at 72 characters)
Enable linting for dropdown.vue
Currently, stylelint is only enabled for css files. Vue components may
also contain <style> tags with valid css but these are not linted.
Let's enable stylelint css for vue files to provide linting to them as well.
Checklist: ☑️