Move docs deployment from Travis CI to GitHub Actions#1759
Merged
Conversation
ong6
requested changes
Feb 11, 2022
Contributor
There was a problem hiding this comment.
Nice work! The changes so far look good! I don't think this exactly fixes the issue of #1386 but will certainly help reduce the build minutes with Travis. I think I'll leave it to one of the senior dev's to approve this PR instead.
ong6
previously approved these changes
Feb 11, 2022
jonahtanjz
reviewed
Feb 12, 2022
Co-authored-by: Jonah Tan <47470981+jonahtanjz@users.noreply.github.com>
jonahtanjz
reviewed
Feb 12, 2022
jonahtanjz
left a comment
Contributor
There was a problem hiding this comment.
Thanks @tlylt
One last thing, I noticed that our README file still has the build status badge pointing to Travis. Will need to update this as well :)
Contributor
Author
Yup sorry forgot about it, will change accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
DevOps
Overview of changes:
Fixes #1386
package.jsonnpm run build:ugetc commandsAnything you'd like to highlight / discuss:
Not able to test this locally, but I have created a sample repo to test the CI logic, which seems to be correct. Some intended runs as follows:
Testing instructions:
See above. Reference: Workflow syntax
Proposed commit message: (wrap lines at 72 characters)
Move docs deployment from Travis CI to GitHub Actions
There is a change to Travis' pricing model.
Let's move docs deployment into GitHub Actions and remove
the usage of Travis from our CI processes.
This will potentially remove any costs incurred when using Travis.
Checklist: ☑️