Skip to content

Bootstrap 5: Prevent Navbars from being printed #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonahtanjz merged 3 commits into from
Apr 15, 2022
Merged

Bootstrap 5: Prevent Navbars from being printed #1906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d539a8
Make Navbar non-printed
jovyntls Apr 15, 2022
5fbcd91
Linting
jovyntls Apr 15, 2022
d1747c9
Fix tests
jovyntls Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/vue-components/src/Navbar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
<template>
<div>
<nav ref="navbar" :class="['navbar', 'navbar-expand-md', themeOptions, addClass, fixedOptions]">
<nav
ref="navbar"
:class="['navbar', 'navbar-expand-md', 'd-print-none', themeOptions, addClass, fixedOptions]"
>
<div class="container-fluid">
<div class="navbar-left">
<slot name="brand"></slot>
Expand Down
8 changes: 4 additions & 4 deletions packages/vue-components/src/__tests__/__snapshots__/Navbar.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`Navbar and secondary navbar navbar with page nav button 1`] = `
<div>
<nav
class="navbar navbar-expand-md navbar-dark bg-primary"
class="navbar navbar-expand-md d-print-none navbar-dark bg-primary"
>
<div
class="container-fluid"
Expand Down Expand Up @@ -68,7 +68,7 @@ exports[`Navbar and secondary navbar navbar with page nav button 1`] = `
exports[`Navbar and secondary navbar navbar with site and page nav buttons 1`] = `
<div>
<nav
class="navbar navbar-expand-md navbar-dark bg-primary"
class="navbar navbar-expand-md d-print-none navbar-dark bg-primary"
>
<div
class="container-fluid"
Expand Down Expand Up @@ -135,7 +135,7 @@ exports[`Navbar and secondary navbar navbar with site and page nav buttons 1`] =
exports[`Navbar and secondary navbar navbar with site nav button 1`] = `
<div>
<nav
class="navbar navbar-expand-md navbar-dark bg-primary"
class="navbar navbar-expand-md d-print-none navbar-dark bg-primary"
>
<div
class="container-fluid"
Expand Down Expand Up @@ -200,7 +200,7 @@ exports[`Navbar and secondary navbar navbar with site nav button 1`] = `
exports[`Navbar and secondary navbar navbar without site and page nav buttons 1`] = `
<div>
<nav
class="navbar navbar-expand-md navbar-dark bg-primary"
class="navbar navbar-expand-md d-print-none navbar-dark bg-primary"
>
<div
class="container-fluid"
Expand Down