Pass SiteConfig to reduce duplication within PageConfig#1990
Merged
Conversation
Contributor
|
Just a quick check - does this preserve live reload support for the properties in |
Contributor
Author
Hi @ang-zeyu, forgot about this 😅, doing a quick test it seems like the typical changes such as updating "titlePrefix", "title", "style" in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Fixes #1986
Anything you'd like to highlight/discuss:
nil
Testing instructions:
nil, covered by existing CI tests.
Proposed commit message: (wrap lines at 72 characters)
Update config objects within site & page
PageConfig has a lot of duplicate properties with SiteConfig.
Let's pass a reference of SiteConfig into Page so that required
properties can be retrieved directly from SiteConfig.
This makes common properties of a site available to processes
in Page and avoids adding those properties into PageConfig.
Checklist: ☑️