Migrate Site.test to Typescript

[yiwen101]

What is the purpose of this pull request?

• Documentation update
• Bug fix
• Feature addition or enhancement
• Code maintenance
• DevOps
• Improve developer experience
• Others, please explain:

Overview of changes:
Mostly some type cleaning and method arguments alignment. Working on #1913.

Anything you'd like to highlight/discuss:

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Migrate Site.test to Typescript

---

Checklist: ☑️

• Updated the documentation for feature additions and enhancements
• Added tests for bug fixes or features
• Linked all related issues
• No unrelated changes

---

Reviewer checklist:

Indicate the SEMVER impact of the PR:

• Major (when you make incompatible API changes)
• Minor (when you add functionality in a backward compatible manner)
• Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

• To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

• what was the old feature that was made obsolete
• any replacement feature (if any), and
• how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.11%. Comparing base (e95e588) to head (d86cc3f).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2481   +/-   ##
=======================================
  Coverage   51.11%   51.11%           
=======================================
  Files         124      124           
  Lines        5355     5355           
  Branches     1152     1152           
=======================================
  Hits         2737     2737           
  Misses       2328     2328           
  Partials      290      290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jflam1301]

LGTM!

[kaixin-hc]

@yiwen101 Could you also remove the .js file in this PR? When pulling your branch I still see it

[yiwen101]

@yiwen101 Could you also remove the .js file in this PR? When pulling your branch I still see it

Thanks for pulling my branch to test it.
It is removed(renamed).
I think you still see it because the js file is ignored due to gitignore?

[kaixin-hc]

okay! Sorry about earlier - my editor i think cached the file so it looked like the .js file was being tracked and not properly ignored. But it is ignored, so all looks good to me : )