Add missing documentation for attributes overridden by slots#2526
Merged
Conversation
4 tasks
yucheng11122017
approved these changes
Apr 25, 2024
yucheng11122017
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you for the work @luminousleek. I think this covers all the overridable attributes that we missed.
itsyme
approved these changes
Apr 25, 2024
itsyme
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the effort in updating the docs!
|
@itsyme Each PR must have a SEMVER impact label, please remember to label the PR properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Fixes #2516. Related to #2476
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Add docs for attributes overridden by slots
Currently, some attributes for the a-point, panel, quiz, tab,
tab-group and tooltip components are able to be overridden by
slots, but this is not reflected in the docs.
Let's update the docs to show this.
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):