Revert Local Mermaid Bundling#2685
Merged
Merged
Conversation
This reverts commit 1856da1.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2685 +/- ##
========================================
Coverage 52.02% 52.02%
========================================
Files 130 130
Lines 7162 7162
Branches 1501 1596 +95
========================================
Hits 3726 3726
+ Misses 3281 3131 -150
- Partials 155 305 +150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tim-Siu
approved these changes
Apr 13, 2025
Tim-Siu
left a comment
Tim-Siu
left a comment
Contributor
There was a problem hiding this comment.
Since the commit tree is clean, this auto-reversion is correct and passes the test. LGTM!
|
@lhw-1 Each PR must have a SEMVER impact label, please remember to label the PR properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts #2677.
There are regressions caused by #2677; given that the errors are likely unrelated to the Vue 3 Migration as pointed out by @Tim-Siu in a comment on #2667, we can revert this change for now, and take another look at the core issues after the v6 release.